Add back root override for strict mode #21428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
rickhanlonii
commented
May 4, 2021
| mode |= StrictEffectsMode; | ||
| } | ||
| } | ||
| } else if (enableStrictEffects && createRootStrictEffectsByDefault) { |
Member
Author
There was a problem hiding this comment.
We can delete this after some internal clean ups.
bvaughn
approved these changes
May 4, 2021
|
Comparing: d1542de...b847f1f Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
rickhanlonii
force-pushed
the
rh-strict-root-option
branch
from
304a5b2 to
b4e9696
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds back a
unstable_strictModeoption to the root which allows opt-ing into strict mode at the root.This keeps the levels implementation, which is used for the strict effects GK, but collapses it to a single option until theres sufficient demand for opting into different levels at the root.